Skip to content

[chore][configtls] Add goleak test via metadata.yaml #15632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mx-psi merged 6 commits into from
Jul 22, 2026
Merged

[chore][configtls] Add goleak test via metadata.yaml #15632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
628ff43
[chore][configtls] Add goleak test via metadata.yaml
mx-psi Jul 21, 2026
0c52dbc
Merge branch 'main' into configtls-goleak-testmain
mx-psi Jul 21, 2026
b4a7ef9
Add additional exclude
mx-psi Jul 22, 2026
7d61375
Spellcheck:
mx-psi Jul 22, 2026
dc4e19d
make gotidy
mx-psi Jul 22, 2026
a2f2e1f
imports ordering:
mx-psi Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/utils/cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@
"incorrectclass",
"incorrectcomponent",
"incorrectstability",
"inotify",
"instrgen",
"internaldata",
"ints",
Expand Down
2 changes: 2 additions & 0 deletions config/configtls/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@
// Package configtls implements the TLS settings to load and
// configure TLS clients and servers.
package configtls // import "go.opentelemetry.io/collector/config/configtls"

//go:generate mdatagen metadata.yaml
13 changes: 13 additions & 0 deletions config/configtls/generated_package_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions config/configtls/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ require (
go.opentelemetry.io/collector/config/configopaque v1.63.0
go.opentelemetry.io/collector/confmap v1.63.0
go.opentelemetry.io/collector/internal/testutil v0.157.0
go.uber.org/goleak v1.3.0
)

require (
Expand Down
11 changes: 11 additions & 0 deletions config/configtls/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,14 @@ github_project: open-telemetry/opentelemetry-collector
status:
disable_codecov_badge: true
class: pkg

tests:
goleak:
ignore:
top:
# https://github.com/open-telemetry/opentelemetry-collector/issues/9221
- "go.opentelemetry.io/collector/config/configtls.(*clientCAsFileReloader).handleWatcherEvents"
any:
# https://github.com/open-telemetry/opentelemetry-collector/issues/9221
- "github.com/fsnotify/fsnotify.(*inotify).readEvents"
Comment thread
songy23 marked this conversation as resolved.
- "github.com/fsnotify/fsnotify.(*readDirChangesW).readEvents"
Loading