[bug][cmd/mdatagen] mdatagen fix versioned metric collision logic#15649
Open
osullivandonal wants to merge 2 commits into
Open
[bug][cmd/mdatagen] mdatagen fix versioned metric collision logic#15649osullivandonal wants to merge 2 commits into
osullivandonal wants to merge 2 commits into
Conversation
Fix incorrect collision warning logged for versioned metrics with different names. Previously, the same-name collision detection (type/attribute check) ran unconditionally for all migrations, causing warnings and incorrectly disabling legacy metrics when legacy and v1 had different names. Test coverage was also added here for this issue.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15649 +/- ##
==========================================
+ Coverage 91.03% 91.05% +0.01%
==========================================
Files 729 729
Lines 48491 48477 -14
==========================================
- Hits 44144 44140 -4
+ Misses 3020 3013 -7
+ Partials 1327 1324 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix incorrect collision warning logged for versioned metrics with different names. Previously, the same-name collision detection (type/attribute check) ran unconditionally for all migrations, causing warnings and incorrectly disabling legacy metrics when legacy and v1 had different names. Test coverage was also added here for this issue.
Link to tracking issue
Fixes #15648
Testing
metrics_test.go.tmpl was updated with a test that is generated for versioned metrics where legacy and v1 have different names. This tests that no warning log msg is recorded.
Authorship