[bug][mdatagen] Auto-enable v1 metrics when legacy is enabled#15651
[bug][mdatagen] Auto-enable v1 metrics when legacy is enabled#15651osullivandonal wants to merge 1 commit into
Conversation
When the v1 feature gate is on and a legacy metric is enabled, programmatically enable the corresponding v1 metric so users don't need to update their config to get v1 metric emission.
9e7ccd1 to
bcde0c1
Compare
Merging this PR will improve performance by 22.45%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | BenchmarkTraceSizeSpanCount |
60 ns | 49 ns | +22.45% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing osullivandonal:mdatagen-fix-auto-enable-versioned-metrics (bcde0c1) with main (52e6bf4)
Footnotes
-
4 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #15651 +/- ##
==========================================
- Coverage 91.03% 91.02% -0.02%
==========================================
Files 729 729
Lines 48491 48499 +8
==========================================
Hits 44144 44144
- Misses 3020 3026 +6
- Partials 1327 1329 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
When the v1 feature gate is on and a legacy metric is enabled, programmatically enable the corresponding v1 metric so users don't need to update their config to get v1 metric emitted.
Link to tracking issue
Fixes #15650
Authorship