Fix grammatical errors and remove duplicate code in logs_router#15655
Open
farhan11166 wants to merge 1 commit into
Open
Fix grammatical errors and remove duplicate code in logs_router#15655farhan11166 wants to merge 1 commit into
farhan11166 wants to merge 1 commit into
Conversation
This commit addresses several minor issues across the codebase:
- connector: Removed duplicate `Consumer` and `PipelineIDs` methods
from `logsRouter` that shadowed the embedded `BaseRouter` methods.
This also resolves a variable shadowing issue where `var errors error`
shadowed the imported `errors` package.
- service/internal/graph: Fixed grammatically incorrect error messages
in the graph builders that produced strings like "error creating
exporter X is not supported".
- exporter/exporterhelper: Fixed grammar in queue comments ("consumer don't"
to "consumers don't", and "allow distinguish" to "allow distinguishing").
- processor/batchprocessor: Fixed godoc grammar ("batcher is describes").
farhan11166
requested review from
a team,
bogdandrutu and
dmitryax
as code owners
July 24, 2026 17:14
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses several minor issues across the codebase:
ConsumerandPipelineIDsmethods fromlogsRouterthat shadowed the embeddedBaseRoutermethods. This also resolves a variable shadowing issue wherevar errors errorshadowed the importederrorspackage.Description
Link to tracking issue
Fixes #
Testing
Documentation
Authorship