[chore][cmd/mdatagen] Align types for mdatagen configs#15659
Open
jkoronaAtCisco wants to merge 3 commits into
Open
[chore][cmd/mdatagen] Align types for mdatagen configs#15659jkoronaAtCisco wants to merge 3 commits into
jkoronaAtCisco wants to merge 3 commits into
Conversation
jkoronaAtCisco
marked this pull request as draft
July 24, 2026 20:05
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (85.71%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #15659 +/- ##
==========================================
- Coverage 91.03% 91.02% -0.02%
==========================================
Files 729 729
Lines 48491 48463 -28
==========================================
- Hits 44144 44113 -31
- Misses 3020 3024 +4
+ Partials 1327 1326 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jkoronaAtCisco
marked this pull request as ready for review
July 24, 2026 20:28
dmitryax
approved these changes
Jul 24, 2026
| if md.Items != nil { | ||
| // []T — item type uses propName+"_item", matching MapGoType | ||
| collectDefsForSchema(propName+"_item", md.Items, defs) | ||
| case "slice", "map": |
Member
There was a problem hiding this comment.
Let's move them all to enum constants. See the pattern we follow in the repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace JSON Schema vocabulary with Go-centric types in mdatagen config schema:
int/bool/slice/mapinstead ofinteger/boolean/array/object, and mergeitems/additionalPropertiesinto a singlevaluesfield.Testing
Unit tests and sample component aligned.
Documentation
Authorship