test: add unit tests for mergeAppend, mergeSlice, and isPresent in confmap/internal - #15663
Open
manoj-1407 wants to merge 1 commit into
Open
test: add unit tests for mergeAppend, mergeSlice, and isPresent in confmap/internal#15663manoj-1407 wants to merge 1 commit into
manoj-1407 wants to merge 1 commit into
Conversation
…nfmap/internal Signed-off-by: manoj-1407 <manojkumar148700@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
confmap/internal/merge.gocontains non-trivial logic for merging configuration maps (mergeAppend,mergeSlice,isPresent) but had no test coverage.Changes
Added
confmap/internal/merge_test.gowith table-driven tests covering:TestMergeAppend_NonOverlappingKeys— verifies both slices are merged under glob-matched keysTestMergeAppend_DeduplicatesSliceEntries— verifies no duplication when src entry already exists in destTestMergeAppend_EmptyDest— verifies src populates an empty destTestMergeAppend_EmptySrc— verifies dest is unchanged when src is emptyTestMergeAppend_NonGlobKeyNotMergedAsSlice— verifies non-glob keys follow standard maps.Merge behaviorTestMergeAppend_PipelineReceiversMerged— verifies pipeline receiver lists merge correctly via glob patternTestMergeSlice_AppendsUniqueElements— dest elements first, unique src elements appendedTestMergeSlice_EmptySrc/TestMergeSlice_EmptyDest/TestMergeSlice_AllDuplicates— edge casesTestIsPresent— table-driven across present, not present, empty slice, map value casesTesting