Skip to content

[memorylimiter] Add disable_gc configuration option (rebased) - #15666

Open
agoallikmaa wants to merge 1 commit into
open-telemetry:mainfrom
agoallikmaa:memlimit-gc-disable
Open

[memorylimiter] Add disable_gc configuration option (rebased)#15666
agoallikmaa wants to merge 1 commit into
open-telemetry:mainfrom
agoallikmaa:memlimit-gc-disable

Conversation

@agoallikmaa

Copy link
Copy Markdown
Contributor

This is #15092 by @vyagh rebased to resolve conflicts, as it appears the original author is not currently continuing on it.

Original description:

Adds a disable_gc configuration option to the memory_limiter processor. This allows users to opt out of forced garbage collection while maintaining logic for data refusal when memory limits are exceeded, supporting scenarios where multiple memory limiters are composed across pipelines.

Fixes #15081

Co-authored-by: Shubham Sharma <vyagh.vy@gmail.com>
@agoallikmaa
agoallikmaa requested a review from a team as a code owner July 27, 2026 16:41
@agoallikmaa
agoallikmaa requested a review from bogdandrutu July 27, 2026 16:41
@codspeed-hq

codspeed-hq Bot commented Jul 27, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 22.45%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
✅ 2 untouched benchmarks
🗄️ 2 archived benchmarks run1

Performance Changes

Benchmark BASE HEAD Efficiency
BenchmarkTraceSizeSpanCount 60 ns 49 ns +22.45%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing agoallikmaa:memlimit-gc-disable (9e0673a) with main (52e6bf4)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.03%. Comparing base (52e6bf4) to head (9e0673a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15666      +/-   ##
==========================================
- Coverage   91.03%   91.03%   -0.01%     
==========================================
  Files         729      729              
  Lines       48491    48493       +2     
==========================================
  Hits        44144    44144              
- Misses       3020     3021       +1     
- Partials     1327     1328       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[process/memorylimiter] Allow disabling GC

1 participant