[chore] Use mdatagen for configopaque and configtelemetry - #15696
Open
inshining wants to merge 2 commits into
Open
[chore] Use mdatagen for configopaque and configtelemetry#15696inshining wants to merge 2 commits into
inshining wants to merge 2 commits into
Conversation
These were the last two config packages still using a hand-written package_test.go. Adds the //go:generate directive and replaces the hand-written goleak TestMain with the mdatagen-generated generated_package_test.go, completing the migration started in open-telemetry#15632 and open-telemetry#15639. Assisted-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completes the mdatagen migration for the
config/packages.configopaqueandconfigtelemetrywere the only two left using a hand-writtenpackage_test.goafter #15639.Link to tracking issue
No dedicated tracking issue
this follows the same pattern established in #15632 and #15639. Happy to open a tracking issue first if maintainers would prefer that.
Testing
go test -count=1 ./...passes for bothconfig/configopaqueandconfig/configtelemetry.Authorship