[chore] confighttp: drop reference to the removed framedSnappy gate - #15702
Open
karpovantonme wants to merge 3 commits into
Open
[chore] confighttp: drop reference to the removed framedSnappy gate#15702karpovantonme wants to merge 3 commits into
karpovantonme wants to merge 3 commits into
Conversation
The confighttp.framedSnappy feature gate was stabilized in open-telemetry#15096 and removed in open-telemetry#15420. The README still presents x-snappy-framed as conditional on that gate, while the encoding is now always available. Signed-off-by: Anton Karpov <karpovantonme@gmail.com>
|
|
Author
|
/easycla |
songy23
approved these changes
Aug 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15702 +/- ##
=======================================
Coverage 91.07% 91.07%
=======================================
Files 730 730
Lines 48499 48499
=======================================
Hits 44169 44169
Misses 3011 3011
Partials 1319 1319 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
/easycla |
evan-bradley
enabled auto-merge
August 3, 2026 14:26
songy23
added
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The README for
confighttpcurrently states thatx-snappy-framedis only available when theconfighttp.framedSnappyfeature gate is enabled. However, this feature gate was stabilized in #15096 and removed in #15420.The encoding is now active by default and present in
config/confighttp/compression.go, as well as in the compressor and decompressor. This PR removes the outdated feature gate condition from the README to match the actual behavior.Link to tracking issue
N/A
Testing
Documentation fix only. No code changes.
Documentation
Updated
confighttp/README.mdto accurately reflect current codebase behavior.Authorship