Skip to content

[scraperhelper] Use {record} unit for log and profile record metrics #15730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mx-psi merged 2 commits into from
Aug 5, 2026
Merged

[scraperhelper] Use {record} unit for log and profile record metrics #15730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e523062
[scraperhelper] Use {record} unit for log and profile record metrics
mx-psi Aug 5, 2026
70d79b4
Apply suggestions from code review
mx-psi Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .chloggen/scraperhelper-log-record-unit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
change_type: bug_fix

component: pkg/scraperhelper

note: Use `{record}` instead of `{datapoint}` as the unit of the log record and profile record scraper metrics

issues: [15730]

subtext: |
Affects `otelcol_scraper_scraped_log_records`, `otelcol_scraper_errored_log_records`,
`otelcol_scraper_scraped_profile_records` and `otelcol_scraper_errored_profile_records`.

change_logs: [user]
4 changes: 2 additions & 2 deletions scraper/scraperhelper/documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Number of log records that were unable to be scraped.

| Unit | Metric Type | Value Type | Monotonic | Stability |
| ---- | ----------- | ---------- | --------- | --------- |
| {datapoint} | Sum | Int | true | Alpha |
| {record} | Sum | Int | true | Alpha |

### otelcol_scraper_errored_metric_points

Expand All @@ -28,7 +28,7 @@ Number of log records successfully scraped.

| Unit | Metric Type | Value Type | Monotonic | Stability |
| ---- | ----------- | ---------- | --------- | --------- |
| {datapoint} | Sum | Int | true | Alpha |
| {record} | Sum | Int | true | Alpha |

### otelcol_scraper_scraped_metric_points

Expand Down
4 changes: 2 additions & 2 deletions scraper/scraperhelper/internal/metadata/generated_telemetry.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions scraper/scraperhelper/internal/metadatatest/generated_telemetrytest.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions scraper/scraperhelper/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ telemetry:
enabled: true
stability: alpha
description: Number of log records that were unable to be scraped.
unit: "{datapoint}"
unit: "{record}"
sum:
value_type: int
monotonic: true
Expand All @@ -35,7 +35,7 @@ telemetry:
enabled: true
stability: alpha
description: Number of log records successfully scraped.
unit: "{datapoint}"
unit: "{record}"
sum:
value_type: int
monotonic: true
Expand Down
4 changes: 2 additions & 2 deletions scraper/scraperhelper/xscraperhelper/documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ Number of profile records that were unable to be scraped.

| Unit | Metric Type | Value Type | Monotonic | Stability |
| ---- | ----------- | ---------- | --------- | --------- |
| {datapoint} | Sum | Int | true | Alpha |
| {record} | Sum | Int | true | Alpha |

### otelcol_scraper_scraped_profile_records

Number of profile records successfully scraped.

| Unit | Metric Type | Value Type | Monotonic | Stability |
| ---- | ----------- | ---------- | --------- | --------- |
| {datapoint} | Sum | Int | true | Alpha |
| {record} | Sum | Int | true | Alpha |
4 changes: 2 additions & 2 deletions scraper/scraperhelper/xscraperhelper/internal/metadata/generated_telemetry.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions scraper/scraperhelper/xscraperhelper/internal/metadatatest/generated_telemetrytest.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions scraper/scraperhelper/xscraperhelper/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ telemetry:
enabled: true
stability: alpha
description: Number of profile records that were unable to be scraped.
unit: "{datapoint}"
unit: "{record}"
sum:
value_type: int
monotonic: true
Expand All @@ -25,7 +25,7 @@ telemetry:
enabled: true
stability: alpha
description: Number of profile records successfully scraped.
unit: "{datapoint}"
unit: "{record}"
sum:
value_type: int
monotonic: true
Loading