Skip to content

[Exporter.Geneva] Fix exporter histogram negative values#3676

Open
Dytroxx wants to merge 1 commit intoopen-telemetry:mainfrom
Dytroxx:fix/geneva-negative-histogram-912
Open

[Exporter.Geneva] Fix exporter histogram negative values#3676
Dytroxx wants to merge 1 commit intoopen-telemetry:mainfrom
Dytroxx:fix/geneva-negative-histogram-912

Conversation

@Dytroxx
Copy link
Copy Markdown

@Dytroxx Dytroxx commented Jan 9, 2026

Fixes #912.

Geneva metric TLV histogram serialization no longer throws when histogram aggregates include negative values. The exporter switches to a double-based payload for sum/min/max when needed, and uses a safe encoding for bucket bounds when bounds are not uint64-compatible.

Tests updated and a new negative-values histogram test added.

@Dytroxx Dytroxx requested a review from a team as a code owner January 9, 2026 13:02
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Jan 9, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Dytroxx / name: Leon Garcia-Egge (c6fe6ef)

@github-actions github-actions bot added comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva perf Performance related labels Jan 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions
Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 25, 2026
@martincostello
Copy link
Copy Markdown
Member

When #3828 is merged, this PR should rebased and extend the fuzz tests to cover the new code.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2026

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@martincostello
Copy link
Copy Markdown
Member

When #3828 is merged, this PR should rebased and extend the fuzz tests to cover the new code.

This has been merged now.

@Dytroxx Dytroxx force-pushed the fix/geneva-negative-histogram-912 branch from 9d41ef3 to c6fe6ef Compare February 11, 2026 14:36
@Dytroxx Dytroxx changed the title Fix Geneva exporter histogram negative values [Exporter.Geneva] Fix exporter histogram negative values Feb 11, 2026
@Dytroxx
Copy link
Copy Markdown
Author

Dytroxx commented Feb 13, 2026

Update: Currently waiting for triage on this #3866
Have to have clear definition how to proceed regarding the precision and handling.

@github-actions
Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 1, 2026

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2026

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 9, 2026
@martincostello martincostello added keep-open Prevents issues and pull requests being closed as stale and removed Stale labels Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva keep-open Prevents issues and pull requests being closed as stale perf Performance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Histogram with negative values

4 participants