[Infra] Docs and tests updates for .NET 10#3868
[Infra] Docs and tests updates for .NET 10#3868martincostello merged 2 commits intoopen-telemetry:mainfrom
Conversation
Cherry-pick changes from open-telemetry#3867: - Update documentation references to .NET 10. - Fix xunit analyzer warnings for untyped data. - "De-code" some documentation references to .NET versions. - Remove version numbers from some unit test names.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3868 +/- ##
==========================================
- Coverage 71.56% 71.43% -0.14%
==========================================
Files 447 457 +10
Lines 17828 17879 +51
==========================================
+ Hits 12759 12772 +13
- Misses 5069 5107 +38 Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR cherry-picks changes from PR #3867 to update documentation and tests for .NET 10. The primary focus is modernizing version references, fixing xunit analyzer warnings, and removing version-specific identifiers from test names.
Changes:
- Updates documentation to use natural language version references (e.g., ".NET 8" instead of
.NET8.0) - Fixes xunit analyzer warnings by converting test data from
IEnumerable<object[]>to strongly-typedTheoryData<T> - Removes version numbers from unit test method names and test case constraints
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/OpenTelemetry.Instrumentation.Http.Tests/HttpWebRequestTests.cs | Updates comment from "NET9" to "NET 9+" |
| test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.cs | Renames test method from ValidateNet8MetricsAsync to ValidateNetMetricsAsync and updates comment |
| test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.Basic.cs | Updates comment from "NET9" to "NET 9+" |
| test/OpenTelemetry.Instrumentation.Http.Benchmarks/README.md | Updates benchmark command example from net8.0 to net10.0 |
| test/OpenTelemetry.Instrumentation.AspNetCore.Tests/RouteTests/RoutingTests.cs | Refactors to use primary constructor, converts MemberData to use TheoryData pattern, removes this. prefixes |
| test/OpenTelemetry.Instrumentation.AspNetCore.Tests/RouteTests/RoutingTestCases.json | Removes minimumDotnetVersion: 7 from MapGroup test cases |
| test/OpenTelemetry.Instrumentation.AspNetCore.Tests/RouteTests/RoutingTestCases.cs | Converts return type from IEnumerable<object[]> to TheoryData<TestCase> for xunit compatibility |
| test/OpenTelemetry.Instrumentation.AspNetCore.Tests/MetricTests.cs | Renames test methods to remove version numbers |
| test/OpenTelemetry.Instrumentation.AspNetCore.Benchmarks/README.md | Updates benchmark command example from net8.0 to net10.0 |
| test/OpenTelemetry.Extensions.Enrichment.AspNetCore.Tests/OpenTelemetry.Extensions.Enrichment.AspNetCore.Tests.csproj | Simplifies comment from "net8+, net9+" to ".NET 8+" |
| test/OpenTelemetry.Exporter.Geneva.Tests/UnixUserEventsDataTransportTests.cs | Updates command example from net8.0 to net10.0 |
| test/OpenTelemetry.Exporter.Geneva.Tests/Testing.md | Updates command example from net8.0 to net10.0 |
| test/OpenTelemetry.Exporter.Geneva.Tests/LogSerializationTests.cs | Updates command example from net8.0 to net10.0 |
| test/OpenTelemetry.Exporter.Geneva.Benchmarks/README.md | Updates benchmark command example from net8.0 to net10.0 |
| src/Shared/Lock.cs | Updates comments from ".NET9" to ".NET 9" |
| src/OpenTelemetry.Instrumentation.Http/README.md | Converts version references from .NET8.0 to natural language ".NET 8" |
| src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs | Updates comment from "net8.0" to ".NET 8+" and removes version from URL |
| src/OpenTelemetry.Instrumentation.AspNetCore/README.md | Inconsistent updates: mixes ".NET 8" with ".NET 10" references incorrectly |
| .github/ISSUE_TEMPLATE/bug_report.yml | Updates example from net8.0 to net10.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update over-zealous version changes.
40ed846
Changes
Cherry-pick changes from #3867:
Merge requirement checklist
AppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)