[Infra] Use TestContainers for integration tests #4094
Draft
martincostello wants to merge 12 commits intoopen-telemetry:mainfrom
Draft
[Infra] Use TestContainers for integration tests #4094martincostello wants to merge 12 commits intoopen-telemetry:mainfrom
martincostello wants to merge 12 commits intoopen-telemetry:mainfrom
Conversation
Add benchmarks for the Redis instrumentation.
Add a benchmark for end-to-end usage of StackExchange.Redis.
- Use new conventions. - Pass connection to instrumentation. - Update component owners.
Use the same SHA that was in the compose file.
Use interface instead of concrete type to avoid InvalidCastException.
Revert the previous fix as it breaks things - use the old conventions instead for now.
- Use test containers for integration tests. - Remove dedicated integration test workflow. - Fix workflow name. Build on top of open-telemetry#4092.
Add missing usings.
Avoid exception on platforms with Linux Docker not available caused by the class fixture.
- Use TestContainers for Cassandra and Kafka integration tests. - Add missing `using`. - Fix broken assertion on .NET Framework. Builds on top of open-telemetry#4093.
github-actions
bot
added
infra
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4094 +/- ##
==========================================
+ Coverage 72.93% 74.62% +1.69%
==========================================
Files 452 460 +8
Lines 17844 17886 +42
==========================================
+ Hits 13014 13347 +333
+ Misses 4830 4539 -291 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Use a collection fixture for the database fixtures instead of a class collection.
Enable collection of code coverage for the Cassandra instrumentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
using.Builds on top of #4093.
Merge requirement checklist
AppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)