Skip to content

[Redis] Add schema URL to traces#4095

Draft
martincostello wants to merge 2 commits intoopen-telemetry:mainfrom
martincostello:gh-4064-redis
Draft

[Redis] Add schema URL to traces#4095
martincostello wants to merge 2 commits intoopen-telemetry:mainfrom
martincostello:gh-4064-redis

Conversation

@martincostello
Copy link
Copy Markdown
Member

Contributes to #4064.

Changes

Add schema URL to the ActivitySource.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Add schema URL to the `ActivitySource`.

Contributes to open-telemetry#4064.
@github-actions github-actions bot added the comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis label Apr 12, 2026
internal static readonly Version SemanticConventionsVersion = new(1, 23, 0);
internal static readonly ActivitySource ActivitySource = ActivitySourceFactory.Create<StackExchangeRedisConnectionInstrumentation>(SemanticConventionsVersion);

internal static readonly Version SemanticConventionsVersionNew = new(1, 28, 0); // TODO Confirm version - might be 1.37.0
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3084 linked to v1.28.0 in the CHANGELOG, but at the time it was merged the latest version was 1.37.0.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.93%. Comparing base (df6d38d) to head (a56474f).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4095   +/-   ##
=======================================
  Coverage   72.93%   72.93%           
=======================================
  Files         452      452           
  Lines       17844    17849    +5     
=======================================
+ Hits        13014    13019    +5     
  Misses       4830     4830           
Flag Coverage Δ
unittests-Instrumentation.StackExchangeRedis 72.43% <100.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mentation/RedisProfilerEntryToActivityConverter.cs 46.26% <100.00%> (+1.65%) ⬆️
...dis/StackExchangeRedisConnectionInstrumentation.cs 95.89% <100.00%> (+0.05%) ⬆️
...ckExchangeRedis/TracerProviderBuilderExtensions.cs 83.33% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant