[DNM] Performance improvements#4096
Closed
martincostello wants to merge 34 commits intoopen-telemetry:mainfrom
Closed
[DNM] Performance improvements#4096martincostello wants to merge 34 commits intoopen-telemetry:mainfrom
martincostello wants to merge 34 commits intoopen-telemetry:mainfrom
Conversation
Avoid adding tags for ASP.NET Core activities where ASP.NET Core has native support to add them itself.
Add CHANGELOG entry.
Fix markdown lint warnings.
Fix CHANGELOG and comment.
Fix incorrect pattern matching on non-nullable `PathString`.
Add schema URL to the `ActivitySource`. Contributes to open-telemetry#4064.
Remove redundant test code for .NET Framework.
- Make CHANGELOG more specific. - Remove unused using statement.
Use `ActivitySourceFactory` to create the `Activity`.
Revert `sealed`.
Remove trailing space.
Still needs a line between entries.
Add optimizations, recommended by Copilot, to reduce allocations in `HttpInListener.OnStopActivity()`: - Cache activity display names. - Uses slices instead of `Regex`. - Avoid enum reflection.
Add new tests to extend patch coverage.
Also check if `statusCode` is negative.
Have a single benchmark that uses the test host and remove various cruft.
Add a benchmark for a gRPC service.
Fix missing configuration to enable it.
Null check delegates to avoid try-catch blocks.
Add simpler benchmarks for HTTP and gRPC using the ASP.NET Core test server.
- Use SetCustomProperty to check for who made the instrumentation. - Avoid running gRPC-related code for HTTP 1.1. - Avoid additional check for the normalized HTTP method.
Ensure the metrics pipeline is active.
Ensure the metrics pipeline is active.
Use existing constant instead of literal.
Use pattern matching on nullable.
Update the README and fix the formatting.
Add missing using.
martincostello
requested a deployment
to
external
GitHub Actions
Waiting
github-actions
bot
added
infra
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Combines the changes from the following PRs so I can get a single set of NuGet packages from CI to test:
Not intended for review or to be merged.
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)