feat(opentelemetry-collector): support kubernetesEvents in daemonset …#2015
Open
YASHMAHAKAL wants to merge 1 commit intoopen-telemetry:mainfrom
Open
feat(opentelemetry-collector): support kubernetesEvents in daemonset …#2015YASHMAHAKAL wants to merge 1 commit intoopen-telemetry:mainfrom
YASHMAHAKAL wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
…mode Add leader election support for kubernetesEvents preset when running in daemonset mode to prevent event duplication. Fixes open-telemetry#1995 Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
YASHMAHAKAL
requested review from
a team,
TylerHelmuth,
dmitryax and
povilasv
as code owners
Author
|
Greetings @TylerHelmuth, Here's PR #2015, referencing issue #1995...!! |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Member
TylerHelmuth
left a comment
TylerHelmuth
left a comment
There was a problem hiding this comment.
I forgot to hit submit on my review :( sorry about that.
Member
There was a problem hiding this comment.
A CI test is enough, we dont need a specific example for this use case.
Member
|
@YASHMAHAKAL Any chance to move forward with the CI fix to move forward with this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds leader election support for kubernetesEvents preset in DaemonSet mode to prevent event duplication.
Fixes #1995
Changes:
disableLeaderElectionoption to values.yamlk8s_leader_electorextension for DaemonSet modeTesting: