Add opentelemetry-ebpf-instrumentation unittests#2034
Open
MrAlias wants to merge 8 commits intoopen-telemetry:mainfrom
Open
Add opentelemetry-ebpf-instrumentation unittests#2034MrAlias wants to merge 8 commits intoopen-telemetry:mainfrom
MrAlias wants to merge 8 commits intoopen-telemetry:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive unit tests for the opentelemetry-ebpf-instrumentation Helm chart using helm-unittest and introduces a GitHub Actions workflow to validate chart changes. The tests cover core chart templates including the DaemonSet, ConfigMap, Service, ServiceMonitor, RBAC resources, and k8s cache components.
Changes:
- Added 7 helm-unittest test files covering all major chart templates
- Added GitHub Actions workflow for automated testing on PRs
- Updated .helmignore to exclude test files and snapshots from chart package
- Bumped chart version from 0.4.1 to 0.4.2
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| charts/opentelemetry-ebpf-instrumentation/tests/servicemonitor_test.yaml | Tests ServiceMonitor rendering with service and internal metrics configurations |
| charts/opentelemetry-ebpf-instrumentation/tests/service_test.yaml | Tests Service creation with metrics and internal metrics ports |
| charts/opentelemetry-ebpf-instrumentation/tests/rbac_test.yaml | Tests RBAC resources (ClusterRole, ClusterRoleBinding, ServiceAccount) creation and disablement |
| charts/opentelemetry-ebpf-instrumentation/tests/daemonset_test.yaml | Tests DaemonSet rendering with default settings and external ConfigMap support |
| charts/opentelemetry-ebpf-instrumentation/tests/configmap_test.yaml | Tests ConfigMap creation and external ConfigMap configuration |
| charts/opentelemetry-ebpf-instrumentation/tests/cache_service_test.yaml | Tests k8s cache Service rendering based on replica configuration |
| charts/opentelemetry-ebpf-instrumentation/tests/cache_deployment_test.yaml | Tests k8s cache Deployment rendering based on replica configuration |
| charts/opentelemetry-ebpf-instrumentation/Chart.yaml | Version bump to 0.4.2 |
| charts/opentelemetry-ebpf-instrumentation/.helmignore | Excludes test files from chart package |
| .github/workflows/ebpf-instrumentation-test.yaml | GitHub Actions workflow for running helm-unittest and chart-testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
charts/opentelemetry-ebpf-instrumentation/tests/servicemonitor_test.yaml
Show resolved
Hide resolved
Include missing prometheus_export in test.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
charts/opentelemetry-ebpf-instrumentation/tests/cache_deployment_test.yaml
Show resolved
Hide resolved
# Conflicts: # charts/opentelemetry-ebpf-instrumentation/.helmignore # charts/opentelemetry-ebpf-instrumentation/Chart.yaml # charts/opentelemetry-ebpf-instrumentation/examples/default/rendered/clusterrole.yaml # charts/opentelemetry-ebpf-instrumentation/examples/default/rendered/clusterrolebinding.yaml # charts/opentelemetry-ebpf-instrumentation/examples/default/rendered/configmap.yaml # charts/opentelemetry-ebpf-instrumentation/examples/default/rendered/daemonset.yaml # charts/opentelemetry-ebpf-instrumentation/examples/default/rendered/serviceaccount.yaml # charts/opentelemetry-ebpf-instrumentation/examples/with-k8s-cache/rendered/cache-deployment.yaml # charts/opentelemetry-ebpf-instrumentation/examples/with-k8s-cache/rendered/cache-service.yaml # charts/opentelemetry-ebpf-instrumentation/examples/with-k8s-cache/rendered/clusterrole.yaml # charts/opentelemetry-ebpf-instrumentation/examples/with-k8s-cache/rendered/clusterrolebinding.yaml # charts/opentelemetry-ebpf-instrumentation/examples/with-k8s-cache/rendered/configmap.yaml # charts/opentelemetry-ebpf-instrumentation/examples/with-k8s-cache/rendered/daemonset.yaml # charts/opentelemetry-ebpf-instrumentation/examples/with-k8s-cache/rendered/serviceaccount.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.