Fix: collector chart override externalTrafficPolicy for NodePort svc#2038
Open
grzegdl wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Fix: collector chart override externalTrafficPolicy for NodePort svc#2038grzegdl wants to merge 1 commit intoopen-telemetry:mainfrom
grzegdl wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
grzegdl
requested review from
a team,
TylerHelmuth,
dmitryax and
povilasv
as code owners
|
|
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can drastically reduce the number of DNS entries by leveraging the externalTrafficPolicy: Local support in external-dns. This ensures that the domain only points to nodes hosting active pods, keeping the DNS configuration clean and improving routing efficiency by avoiding nodes without local endpoints. This is extremely important for large k8s clusters.
External-dns already supports it - kubernetes-sigs/external-dns#1023