Skip to content

Remove unnecessary muzzle skip versions after lenient resolution change #16830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Remove unnecessary muzzle skip versions after lenient resolution change #16830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3be9357
Remove muzzle skip versions that are outside the declared version range
Copilot Mar 20, 2026
cf61f99
Revert play-mvc-2.4 and spring-webmvc-3.1 skip removals that caused m…
Copilot Mar 20, 2026
11098e7
Remove more muzzle skip versions (Phase 2)
Copilot Mar 20, 2026
8c5a385
Merge remote-tracking branch 'upstream/main' into copilot/remove-skip…
trask Mar 24, 2026
1ac8375
fix
trask Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion instrumentation/alibaba-druid-1.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ muzzle {
group.set("com.alibaba")
module.set("druid")
versions.set("(,)")
skip("1.0.30")
}
}

Expand Down
2 changes: 0 additions & 2 deletions instrumentation/apache-httpclient/apache-httpclient-4.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ muzzle {
module.set("dropwizard-client")
versions.set("(,3.0.0)")
assertInverse.set(true)
// Could not find com.google.code.findbugs:jsr305:.
skip("3.0.2", "4.0.2")
}
}

Expand Down
15 changes: 0 additions & 15 deletions instrumentation/aws-sdk/aws-sdk-2.2/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ muzzle {
excludeInstrumentationName("aws-sdk-2.2-sqs")
excludeInstrumentationName("aws-sdk-2.2-sns")
excludeInstrumentationName("aws-sdk-2.2-lambda")

// several software.amazon.awssdk artifacts are missing for this version
skip("2.17.200")
}

fail {
Expand All @@ -33,9 +30,6 @@ muzzle {
// "fail" asserts that *all* the instrumentation modules fail to load, but the core one is
// actually expected to succeed, so exclude it from checks.
excludeInstrumentationName("aws-sdk-2.2-core")

// several software.amazon.awssdk artifacts are missing for this version
skip("2.17.200")
}

pass {
Expand All @@ -49,9 +43,6 @@ muzzle {
excludeInstrumentationName("aws-sdk-2.2-bedrock-runtime")
excludeInstrumentationName("aws-sdk-2.2-sns")
excludeInstrumentationName("aws-sdk-2.2-lambda")

// several software.amazon.awssdk artifacts are missing for this version
skip("2.17.200")
}

pass {
Expand All @@ -65,9 +56,6 @@ muzzle {
excludeInstrumentationName("aws-sdk-2.2-bedrock-runtime")
excludeInstrumentationName("aws-sdk-2.2-sqs")
excludeInstrumentationName("aws-sdk-2.2-lambda")

// several software.amazon.awssdk artifacts are missing for this version
skip("2.17.200")
}
pass {
group.set("software.amazon.awssdk")
Expand All @@ -80,9 +68,6 @@ muzzle {
excludeInstrumentationName("aws-sdk-2.2-bedrock-runtime")
excludeInstrumentationName("aws-sdk-2.2-sqs")
excludeInstrumentationName("aws-sdk-2.2-sns")

// several software.amazon.awssdk artifacts are missing for this version
skip("2.17.200")
}
pass {
group.set("software.amazon.awssdk")
Expand Down
2 changes: 0 additions & 2 deletions instrumentation/c3p0-0.9/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ muzzle {
group.set("com.mchange")
module.set("c3p0")
versions.set("(,)")
// these versions have missing dependencies in maven central
skip("0.9.2-pre2-RELEASE", "0.9.2-pre3")
}
}

Expand Down
2 changes: 0 additions & 2 deletions instrumentation/camel-2.20/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ muzzle {
module.set("camel-core")
versions.set("[2.19,3)")
assertInverse.set(true)
// https://repo.maven.apache.org/maven2/org/apache/camel/core/4.12.0/core-4.12.0.pom is missing
skip("4.12.0")
}
}

Expand Down
2 changes: 0 additions & 2 deletions instrumentation/couchbase/couchbase-3.1.6/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ muzzle {
group.set("com.couchbase.client")
module.set("java-client")
versions.set("[3.1.6,3.2.0)")
// these versions were released as ".bundle" instead of ".jar"
skip("2.7.5", "2.7.8")
assertInverse.set(true)
}
}
Expand Down
2 changes: 0 additions & 2 deletions instrumentation/couchbase/couchbase-3.1/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ muzzle {
group.set("com.couchbase.client")
module.set("java-client")
versions.set("[3.1,3.1.6)")
// these versions were released as ".bundle" instead of ".jar"
skip("2.7.5", "2.7.8")
assertInverse.set(true)
}
}
Expand Down
2 changes: 0 additions & 2 deletions instrumentation/couchbase/couchbase-3.2/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ muzzle {
group.set("com.couchbase.client")
module.set("java-client")
versions.set("[3.2.0,3.4.0)")
// these versions were released as ".bundle" instead of ".jar"
skip("2.7.5", "2.7.8")
assertInverse.set(true)
}
}
Expand Down
2 changes: 0 additions & 2 deletions instrumentation/couchbase/couchbase-3.4/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ muzzle {
group.set("com.couchbase.client")
module.set("java-client")
versions.set("[3.4.0,)")
// these versions were released as ".bundle" instead of ".jar"
skip("2.7.5", "2.7.8")
assertInverse.set(true)
}
}
Expand Down
7 changes: 0 additions & 7 deletions instrumentation/elasticsearch/elasticsearch-transport-5.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ muzzle {
group.set("org.elasticsearch.client")
module.set("transport")
versions.set("[5.0.0,5.3.0)")
// version 7.11.0 depends on org.elasticsearch:elasticsearch:7.11.0 which depends on
// org.elasticsearch:elasticsearch-plugin-classloader:7.11.0 which does not exist
// version 7.17.8 has broken module metadata
skip("7.11.0", "7.17.8")
// version 8.8.0 depends on elasticsearch:elasticsearch-preallocate which doesn't exist
excludeDependency("org.elasticsearch:elasticsearch-preallocate")
assertInverse.set(true)
Expand All @@ -19,9 +15,6 @@ muzzle {
group.set("org.elasticsearch")
module.set("elasticsearch")
versions.set("[5.0.0,5.3.0)")
// version 7.11.0 depends on org.elasticsearch:elasticsearch:7.11.0 which depends on
// org.elasticsearch:elasticsearch-plugin-classloader:7.11.0 which does not exist
skip("7.11.0")
// version 8.8.0 depends on elasticsearch:elasticsearch-preallocate which doesn't exist
excludeDependency("org.elasticsearch:elasticsearch-preallocate")
assertInverse.set(true)
Expand Down
7 changes: 0 additions & 7 deletions instrumentation/elasticsearch/elasticsearch-transport-5.3/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ muzzle {
group.set("org.elasticsearch.client")
module.set("transport")
versions.set("[5.3.0,6.0.0)")
// version 7.11.0 depends on org.elasticsearch:elasticsearch:7.11.0 which depends on
// org.elasticsearch:elasticsearch-plugin-classloader:7.11.0 which does not exist
// version 7.17.8 has broken module metadata
skip("7.11.0", "7.17.8")
// version 8.8.0 depends on elasticsearch:elasticsearch-preallocate which doesn't exist
excludeDependency("org.elasticsearch:elasticsearch-preallocate")
assertInverse.set(true)
Expand All @@ -19,9 +15,6 @@ muzzle {
group.set("org.elasticsearch")
module.set("elasticsearch")
versions.set("[5.3.0,6.0.0)")
// version 7.11.0 depends on org.elasticsearch:elasticsearch-plugin-classloader:7.11.0
// which does not exist
skip("7.11.0")
// version 8.8.0 depends on elasticsearch:elasticsearch-preallocate which doesn't exist
excludeDependency("org.elasticsearch:elasticsearch-preallocate")
assertInverse.set(true)
Expand Down
7 changes: 0 additions & 7 deletions instrumentation/elasticsearch/elasticsearch-transport-6.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ muzzle {
group.set("org.elasticsearch.client")
module.set("transport")
versions.set("[6.0.0,)")
// version 7.11.0 depends on org.elasticsearch:elasticsearch:7.11.0 which depends on
// org.elasticsearch:elasticsearch-plugin-classloader:7.11.0 which does not exist
// version 7.17.8 has broken module metadata
skip("7.11.0", "7.17.8")
// version 8.8.0 depends on elasticsearch:elasticsearch-preallocate which doesn't exist
excludeDependency("org.elasticsearch:elasticsearch-preallocate")
assertInverse.set(true)
Expand All @@ -19,9 +15,6 @@ muzzle {
group.set("org.elasticsearch")
module.set("elasticsearch")
versions.set("[6.0.0,8.0.0)")
// version 7.11.0 depends on org.elasticsearch:elasticsearch:7.11.0 which depends on
// org.elasticsearch:elasticsearch-plugin-classloader:7.11.0 which does not exist
skip("7.11.0")
// version 8.8.0 depends on elasticsearch:elasticsearch-preallocate which doesn't exist
excludeDependency("org.elasticsearch:elasticsearch-preallocate")
assertInverse.set(true)
Expand Down
7 changes: 0 additions & 7 deletions instrumentation/grails-3.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,6 @@ muzzle {
group.set("org.grails")
module.set("grails-web-url-mappings")
versions.set("[3.0,)")
// version 3.1.15 depends on org.grails:grails-datastore-core:5.0.13.BUILD-SNAPSHOT
// which (obviously) does not exist
// version 3.3.6 depends on org.grails:grails-datastore-core:6.1.10.BUILD-SNAPSHOT
// which (also obviously) does not exist
skip("3.1.15", "3.3.6")
// these versions pass if you add the grails maven repository (https://repo.grails.org/artifactory/core)
skip("3.2.0", "3.3.0", "3.3.1", "3.3.2", "3.3.3", "3.3.10", "3.3.13", "3.3.14", "3.3.15", "3.3.16", "3.3.17", "3.3.18", "4.0.0", "4.0.1", "4.0.5", "4.0.6", "4.0.7", "4.0.8", "4.0.9", "4.0.10", "4.0.11", "4.0.12", "4.0.13")
assertInverse.set(true)
}
}
Expand Down
1 change: 0 additions & 1 deletion instrumentation/guava-10.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ muzzle {
group.set("com.google.guava")
module.set("guava")
versions.set("[10.0,]")
skip("32.1.0-android")
assertInverse.set(true)
}
}
Expand Down
3 changes: 0 additions & 3 deletions instrumentation/hikaricp-3.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ muzzle {
module.set("HikariCP")
versions.set("[3.0.0,)")
// muzzle does not detect PoolStats method references used - some of these methods were introduced in 3.0 and we can't assertInverse

// 4.0.0 uses a broken slf4j version: the "${slf4j.version}" placeholder is taken literally
skip("4.0.0")
}
}

Expand Down
2 changes: 0 additions & 2 deletions instrumentation/javalin/javalin-5.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ muzzle {
group.set("io.javalin")
module.set("javalin")
versions.set("[5.0.0,7.0.0)")
// 3.2.0 depends on org.meteogroup.jbrotli:jbrotli:0.5.0 that is not available in central
skip("3.2.0")
assertInverse.set(true)
}
}
Expand Down
2 changes: 0 additions & 2 deletions instrumentation/javalin/javalin-7.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ muzzle {
group.set("io.javalin")
module.set("javalin")
versions.set("[7.0.0,)")
// 3.2.0 depends on org.meteogroup.jbrotli:jbrotli:0.5.0 that is not available in central
skip("3.2.0")
assertInverse.set(true)
}
}
Expand Down
2 changes: 0 additions & 2 deletions instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-3.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ muzzle {
group.set("org.jboss.resteasy")
module.set("resteasy-jaxrs")
versions.set("(2.1.0.GA,3.0.0.Final)")
// missing dependencies
skip("2.3.10.Final")
}

fail {
Expand Down
2 changes: 0 additions & 2 deletions instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-3.1/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ muzzle {
group.set("org.jboss.resteasy")
module.set("resteasy-jaxrs")
versions.set("(2.1.0.GA,3.1.0.Final)")
// missing dependencies
skip("2.3.10.Final")
}

fail {
Expand Down
5 changes: 0 additions & 5 deletions instrumentation/jaxws/jaxws-2.0-axis2-1.6/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@ muzzle {
module.set("axis2-jaxws")
versions.set("[1.6.0,)")
assertInverse.set(true)
// version 1.2 depends on org.apache.axis2:axis2-kernel:1.2
// which depends on org.apache.neethi:neethi:2.0.1 which does not exist
// version 1.3 depends on org.apache.axis2:axis2-kernel:1.3
// which depends on org.apache.woden:woden:1.0-incubating-M7b which does not exist
skip("1.2", "1.3")
}
}

Expand Down
1 change: 0 additions & 1 deletion instrumentation/jedis/jedis-4.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ muzzle {
group.set("redis.clients")
module.set("jedis")
versions.set("[4.0.0-beta1,)")
skip("jedis-3.6.2")
assertInverse.set(true)
}
}
Expand Down
2 changes: 0 additions & 2 deletions instrumentation/jsp-2.3/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ muzzle {
module.set("tomcat-jasper")
// tomcat 10 uses JSP 3.0
versions.set("[7.0.19,10)")
// version 8.0.9 depends on org.eclipse.jdt.core.compiler:ecj:4.4RC4 which does not exist
skip("8.0.9")
// not using assertInverse.set(true) because org.eclipse.jdt.core.compiler:ecj:xxx dependency
// is missing for versions in range [7.0.0, 7.0.19)
}
Expand Down
4 changes: 0 additions & 4 deletions instrumentation/ktor/ktor-2.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,13 @@ muzzle {
versions.set("[2.0.0,3.0.0)")
assertInverse.set(true)
excludeInstrumentationName("ktor-server")
// missing dependencies
skip("1.1.0", "1.1.1", "1.1.5")
}
pass {
group.set("io.ktor")
module.set("ktor-server-core")
versions.set("[2.0.0,3.0.0)")
assertInverse.set(true)
excludeInstrumentationName("ktor-client")
// missing dependencies
skip("1.1.0", "1.1.1")
}
}

Expand Down
4 changes: 0 additions & 4 deletions instrumentation/ktor/ktor-3.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,13 @@ muzzle {
versions.set("[3.0.0,)")
assertInverse.set(true)
excludeInstrumentationName("ktor-server")
// missing dependencies
skip("1.1.0", "1.1.1", "1.1.5")
}
pass {
group.set("io.ktor")
module.set("ktor-server-core")
versions.set("[3.0.0,)")
assertInverse.set(true)
excludeInstrumentationName("ktor-client")
// missing dependencies
skip("1.1.0", "1.1.1")
}
}

Expand Down
2 changes: 0 additions & 2 deletions instrumentation/log4j/log4j-appender-1.2/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ muzzle {
group.set("log4j")
module.set("log4j")
versions.set("[1.2,)")
// version 1.2.15 has a bad dependency on javax.jms:jms:1.1 which was released as pom only
skip("1.2.15")
assertInverse.set(true)
}
}
Expand Down
2 changes: 0 additions & 2 deletions instrumentation/log4j/log4j-mdc-1.2/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ muzzle {
group.set("log4j")
module.set("log4j")
versions.set("[1.2,)")
// version 1.2.15 has a bad dependency on javax.jms:jms:1.1 which was released as pom only
skip("1.2.15")
assertInverse.set(true)
}
}
Expand Down
3 changes: 0 additions & 3 deletions instrumentation/logback/logback-appender-1.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ muzzle {
group.set("ch.qos.logback")
module.set("logback-classic")
versions.set("[0.9.16,)")
skip("0.9.6") // has dependency on SNAPSHOT org.slf4j:slf4j-api:1.4.0-SNAPSHOT
skip("0.8") // has dependency on non-existent org.slf4j:slf4j-api:1.1.0-RC0
skip("0.6") // has dependency on pom only javax.jms:jms:1.1
assertInverse.set(true)
}
}
Expand Down
3 changes: 0 additions & 3 deletions instrumentation/nats/nats-2.17/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ muzzle {
module.set("jnats")
versions.set("[2.17.2,)")

// Could not find io.nats:nats-parent:1.0-SNAPSHOT
skip("0.5.0", "0.5.1")

assertInverse.set(true)
}
}
Expand Down
2 changes: 0 additions & 2 deletions instrumentation/opentelemetry-api/opentelemetry-api-1.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ muzzle {
group.set("io.opentelemetry")
module.set("opentelemetry-api")
versions.set("[0.17.0,)")
skip("0.13.0") // has a bad dependency on non-alpha api-metric 0.13.0
skip("0.9.0") // has no pom file in maven central
assertInverse.set(true)
}
}
Expand Down
1 change: 0 additions & 1 deletion instrumentation/opentelemetry-extension-annotations-1.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ muzzle {
group.set("io.opentelemetry")
module.set("opentelemetry-extension-annotations")
versions.set("[0.16.0,)")
skip("0.13.0") // opentelemetry-api has a bad dependency on non-alpha api-metric 0.13.0
assertInverse.set(true)
}
}
Expand Down
1 change: 0 additions & 1 deletion instrumentation/opentelemetry-extension-kotlin-1.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ muzzle {
module.set("opentelemetry-extension-kotlin")
versions.set("[0.17.0,)")
assertInverse.set(true)
skip("0.13.0") // has a bad dependency on non-alpha api-metric 0.13.0
extraDependency("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.0")
}
}
Expand Down
3 changes: 0 additions & 3 deletions instrumentation/play/play-mvc/play-mvc-2.6/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ muzzle {
module.set("play_$scalaVersion")
versions.set("[$playVersion,)")
assertInverse.set(true)
// versions 2.3.9 and 2.3.10 depends on com.typesafe.netty:netty-http-pipelining:1.1.2
// which does not exist
skip("2.3.9", "2.3.10")
}
pass {
group.set("com.typesafe.play")
Expand Down
1 change: 0 additions & 1 deletion instrumentation/quartz-2.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ muzzle {
module.set("quartz")
versions.set("[2.0.0,)")
assertInverse.set(true)
skip("1.7.0") // missing in maven central
}
}

Expand Down
Loading
Loading