Review fixes for internal-application-logger:javaagent#17370
Open
otelbot[bot] wants to merge 3 commits intomainfrom
Open
Review fixes for internal-application-logger:javaagent#17370otelbot[bot] wants to merge 3 commits intomainfrom
otelbot[bot] wants to merge 3 commits intomainfrom
Conversation
Automated code review of instrumentation/internal/internal-application-logger/javaagent.
laurit
reviewed
Apr 1, 2026
| }); | ||
|
|
||
| process.waitFor(10, SECONDS); | ||
| boolean exited = process.waitFor(10, SECONDS); |
Member
There was a problem hiding this comment.
just the verbosity? killing potentially hung test processes seems nice
trask
reviewed
Apr 1, 2026
...lemetry/javaagent/instrumentation/internal/logging/ApplicationLoggerInstrumentationTest.java
Outdated
Show resolved
Hide resolved
…/src/test/java/io/opentelemetry/javaagent/instrumentation/internal/logging/ApplicationLoggerInstrumentationTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewed
instrumentation/internal/internal-application-logger/javaagent, applied 1 safe fix in tests, and validated with:instrumentation:internal:internal-application-logger:javaagent:check,:check -PtestLatestDeps=true,:muzzle, and./gradlew spotlessApply.Applied Changes
[Testing]
File:
ApplicationLoggerInstrumentationTest.java:75Change: Added assertions that the forked subprocess exits within the timeout and returns exit code
0, forcibly destroying it first if it hangs.Reason: The review checklist prioritizes engineering correctness and reliability; a test that only reads subprocess output without asserting successful process completion can pass despite a failed or stuck child process.
Unresolved Items
File:
build.gradle.ktsReason: Did not keep
assertInverse.set(true)on thespring-bootmuzzlepassblock. Althoughgradle-conventions.mdprefersassertInversefor bounded ranges,:instrumentation:internal:internal-application-logger:javaagent:muzzleshowed the instrumentation still passes on Spring Boot1.0.x/1.1.x, so adding the inverse assertion is not a safe fix without a broader muzzle/version-range decision.Download code review diagnostics