Open
Conversation
Automated code review of instrumentation/oshi/javaagent.
laurit
reviewed
Apr 6, 2026
| Method getCurrentPlatformEnumMethod = getCurrentPlatformMethod(oshiSystemInfoClass); | ||
| getCurrentPlatformEnumMethod.invoke(null); | ||
| } catch (Throwable ex) { | ||
| } catch (ReflectiveOperationException | LinkageError exception) { |
Contributor
There was a problem hiding this comment.
should be ClassNotFoundException instead of LinkageError?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applied 1 safe fix in
instrumentation/oshi/javaagentto narrow optional-startup failure handling inOshiMetricsInstallerwithout changing module behavior when OSHI is absent or incompatible.Applied Changes
General
File:
OshiMetricsInstaller.java:35Change: Replaced
catch (Throwable)withcatch (ReflectiveOperationException \| LinkageError)inafterAgent().Reason: The review checklist's correctness and safety rules call for avoiding overly broad exception handling; this keeps optional OSHI activation failures ignored while no longer swallowing unrelated fatal JVM errors.
Download code review diagnostics