Open
Conversation
trask
approved these changes
Apr 7, 2026
Automated code review of instrumentation/rmi/bootstrap.
trask
force-pushed
the
otelbot/code-review-rmi-bootstrap
branch
from
a809a11 to
7a062d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applied a safe review fix in
rmi/bootstrapby renaming the exportedThreadLocalContextsingleton field to canonicalINSTANCEand updating the local RMI javaagent callers to use qualifiedThreadLocalContext.INSTANCEaccess.Applied Changes
Style
File:
ThreadLocalContext.java:12Change: Renamed the exported singleton field from
THREAD_LOCAL_CONTEXTtoINSTANCE.Reason: The style guide and singleton guidance allow uppercase exported singleton fields only in canonical forms such as
INSTANCE;THREAD_LOCAL_CONTEXTexposed a collaborator under a non-canonical constant-style name.File:
ContextDispatcher.java:8Change: Updated the dispatcher to use
ThreadLocalContext.INSTANCEwith a normal class import instead of the old static field import.Reason: This keeps the caller aligned with the canonical singleton rename and avoids Error Prone
BadImportwarnings for static-importing the commonly used nameINSTANCE.File:
RemoteServerInstrumentation.java:8Change: Updated the server instrumentation to call
ThreadLocalContext.INSTANCE.getAndResetContext()via a normal class import.Reason: This keeps the caller aligned with the canonical singleton rename and avoids Error Prone
BadImportwarnings for static-importing the commonly used nameINSTANCE.Download code review diagnostics