Fix the bug in rocketmq-client-4.8 where ONEWAY messages cannot record and export spans.#17656
Open
YaoYingLong wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Fix the bug in rocketmq-client-4.8 where ONEWAY messages cannot record and export spans.#17656YaoYingLong wants to merge 1 commit intoopen-telemetry:mainfrom
rocketmq-client-4.8 where ONEWAY messages cannot record and export spans.#17656YaoYingLong wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
…t record and export spans.
laurit
reviewed
Apr 7, 2026
Contributor
There was a problem hiding this comment.
would it be possible to add a test for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When producing ONEWAY messages using the
sendOnewaymethod ofDefaultMQProducer, span data cannot be recorded or exported.The root cause is that when sending messages in ONEWAY mode, the
SendResultcannot be obtained, and under normal circumstances, no exception is thrown. As a result, the span does not end.Solution: Add a CommunicationMode.ONEWAY check in the sendMessageAfter method of TracingSendMessageHookImpl to ensure the execution of Instrumenter.end.