Open
Conversation
Automated code review of instrumentation/rxjava/rxjava-2.0/javaagent.
trask
approved these changes
Apr 7, 2026
laurit
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applied 2 minimal-visibility fixes under
instrumentation/rxjava/rxjava-2.0/javaagent. Required Gradle validation could not be completed because./gradlew :instrumentation:rxjava:rxjava-2.0:javaagent:checkwas left in an in-progressbashsession with no declared tool available to observe its final exit status, so the follow-up-PtestLatestDeps=truerun and final./gradlew spotlessApplyrun were not performed.Applied Changes
Style
File:
TracingAssemblyActivation.java:13Change: Made
TracingAssemblyActivationandactivate(...)package-private.Reason: The style guide's minimal-visibility rule says internal implementation code should use the most restrictive access that still works; this helper is only referenced inside
io.opentelemetry.javaagent.instrumentation.rxjava.v2_0.File:
BaseRxJava2WithSpanTest.java:928Change: Tightened
CustomPublishervisibility and made itssubscriber,onComplete(), andonError(...)membersprivate.Reason: The style guide's minimal-visibility rule prefers the narrowest access that still works; these test-only members are used only within
BaseRxJava2WithSpanTest.Unresolved Items
File:
javaagentReason: Validation is incomplete:
./gradlew :instrumentation:rxjava:rxjava-2.0:javaagent:checkwas started, but the declaredbashtool returned only an in-progress session and the runtime exposed no declared way to read that session to final completion. Re-run that:checktask to a confirmed exit status, then run./gradlew :instrumentation:rxjava:rxjava-2.0:javaagent:check -PtestLatestDeps=trueand./gradlew spotlessApply.Download code review diagnostics