Skip to content

Review fixes for rxjava-2.0:javaagent#17672

Open
otelbot[bot] wants to merge 2 commits intomainfrom
otelbot/code-review-rxjava-2.0-javaagent
Open

Review fixes for rxjava-2.0:javaagent#17672
otelbot[bot] wants to merge 2 commits intomainfrom
otelbot/code-review-rxjava-2.0-javaagent

Conversation

@otelbot
Copy link
Copy Markdown
Contributor

@otelbot otelbot bot commented Apr 7, 2026

Summary

Applied 2 minimal-visibility fixes under instrumentation/rxjava/rxjava-2.0/javaagent. Required Gradle validation could not be completed because ./gradlew :instrumentation:rxjava:rxjava-2.0:javaagent:check was left in an in-progress bash session with no declared tool available to observe its final exit status, so the follow-up -PtestLatestDeps=true run and final ./gradlew spotlessApply run were not performed.

Applied Changes

Style

File: TracingAssemblyActivation.java:13
Change: Made TracingAssemblyActivation and activate(...) package-private.
Reason: The style guide's minimal-visibility rule says internal implementation code should use the most restrictive access that still works; this helper is only referenced inside io.opentelemetry.javaagent.instrumentation.rxjava.v2_0.

File: BaseRxJava2WithSpanTest.java:928
Change: Tightened CustomPublisher visibility and made its subscriber, onComplete(), and onError(...) members private.
Reason: The style guide's minimal-visibility rule prefers the narrowest access that still works; these test-only members are used only within BaseRxJava2WithSpanTest.

Unresolved Items

File: javaagent
Reason: Validation is incomplete: ./gradlew :instrumentation:rxjava:rxjava-2.0:javaagent:check was started, but the declared bash tool returned only an in-progress session and the runtime exposed no declared way to read that session to final completion. Re-run that :check task to a confirmed exit status, then run ./gradlew :instrumentation:rxjava:rxjava-2.0:javaagent:check -PtestLatestDeps=true and ./gradlew spotlessApply.


Download code review diagnostics

Automated code review of instrumentation/rxjava/rxjava-2.0/javaagent.
@otelbot otelbot bot requested a review from a team as a code owner April 7, 2026 18:41
@trask trask enabled auto-merge (squash) April 7, 2026 18:43
@trask trask disabled auto-merge April 7, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants