Review fixes for jsp-2.3:javaagent

[otelbot]

Summary

Applied safe review fixes in instrumentation/jsp-2.3: added the missing declarative_name coverage in metadata.yaml and tightened test-helper visibility/style in the javaagent test support classes.

Applied Changes

Config

File: metadata.yaml:9
Change: Added declarative_name entries for otel.instrumentation.common.experimental.view-telemetry.enabled and otel.instrumentation.jsp.experimental-span-attributes.
Reason: metadata-yaml-format.md requires every instrumentation metadata.yaml config entry to declare the correct declarative mapping, and both entries were already used by the module code.

Style

File: JspSpan.java:21
Change: Reduced the helper bean accessors and mutators from public to package-private.
Reason: The style guide requires minimal necessary visibility; this test-only helper is package-scoped and only used within the same package.

File: JspSpanAssertionBuilder.java:21
Change: Reduced the builder methods from public to package-private.
Reason: The style guide requires minimal necessary visibility, and this package-scoped test builder does not need public methods.

File: JspSpanAssertions.java:34
Change: Renamed isExperimentalEnabled to EXPERIMENTAL_ENABLED and reduced experimental(String) from public to package-private.
Reason: The style guide treats immutable boolean constants as uppercase constants, and the helper method only needs package-local visibility under the minimal-visibility rule.

---

Download code review diagnostics