Review fixes for google-http-client-1.19:javaagent#18142
Merged
trask merged 1 commit intoApr 22, 2026
Conversation
Automated code review of instrumentation/google-http-client-1.19/javaagent.
trask
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applied a safe metadata fix in
instrumentation/google-http-client-1.19by adding the missingdeclarative_namemappings for the module's existing HTTP client configuration entries.Applied Changes
Config
File:
metadata.yaml:9Change: Added the missing
declarative_nameentries forotel.instrumentation.http.known-methods, HTTP client header capture, and the two experimental HTTP client options.Reason:
metadata-yaml-format.mdrequires configuration entries inmetadata.yamlto carry the correctdeclarative_namemapping so flat properties round-trip correctly through declarative config validation.Download code review diagnostics