adding health check in to health checkv2#4625
adding health check in to health checkv2#4625badal773 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
|
|
E2E Test Results 34 files ±0 227 suites ±0 2h 40m 32s ⏱️ + 36m 25s For more details on these failures, see this check. Results for commit 8646445. ± Comparison against base commit 915d7c2. |
iblancasa
left a comment
There was a problem hiding this comment.
You can just use v2 from v1 enabling a feature gate https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/healthcheckextension#feature-gate-extensionhealthcheckusecomponentstatus
healthcheckv2 will be removed at some point
I don't think this is necessarily a blocker. It'll take a while before that feature gate is enabled by default and healthcheckv2 is deprecated. Looking at this PR, it doesn't cost us much to support it. @open-telemetry/operator-approvers opinions? |
Description:
Add support for healthcheckv2 extension in the OpenTelemetry Operator to enable automatic liveness, readiness, and startup probe generation.
Link to tracking Issue(s):
Testing:
Documentation: