add batch processor deprecation warning#4648
Open
frzifus wants to merge 1 commit intoopen-telemetry:mainfrom
Open
add batch processor deprecation warning#4648frzifus wants to merge 1 commit intoopen-telemetry:mainfrom
frzifus wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
force-pushed
the
batch-processor-deprecation-warning
branch
from
eae0867 to
ec4ffc2
Compare
swiatekm
reviewed
Jan 26, 2026
|
|
||
| func (c *Config) ApplyDefaults(logger logr.Logger) ([]EventInfo, error) { | ||
| return c.applyDefaultForComponentKinds(logger, KindReceiver, KindExtension) | ||
| events, err := c.applyDefaultForComponentKinds(logger, KindReceiver, KindExtension) |
Contributor
There was a problem hiding this comment.
Is the defaulter the best place to put this logic? I'd have expected it to live in the Validate methods and return an admission warning instead of an Event.
Contributor
|
I'm not sure about this because we have this PR in progress: open-telemetry/opentelemetry-collector#13583 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue(s):
Testing:
Documentation: