Fix for issue - #2808: Invalid type WSGIRequest for attribute 'request' value opentelemetry

[rads-1996]

Description

Fixes #2808

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Added tests for Django instrumentation

Does This PR Require a Core Repo Change?

• Yes. - Link to PR:
• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[tammy-baylis-swi]

Thanks again @rads-1996 , this lgtm. Maintainers will also have a look.

[rads-1996]

Thanks again @rads-1996 , this lgtm. Maintainers will also have a look.

Thank you so much. Really appreciate the review :)

[emdneto]

Thanks for the research and the PR, but I'm not sure if the issue is fixed. I'm still able to reproduce it, because Django logging extension (django.request and django.server) is still adding request to extras, which causes logs to be emitted with a request attribute containing an invalid value (WSGIRequest).

I didn't dig into it in detail, but what I imagine can solve the issue is to use a logging filter like:

class RequestFilter(logging.Filter):
    def filter(self, record: logging.LogRecord) -> bool:
        request = getattr(record, "request", None)
        record.request = str(request)
        return True
        
logger = logging.getLogger("django.request")
logger.addFilter(RequestFilter())

[rads-1996]

Thanks for the research and the PR, but I'm not sure if the issue is fixed. I'm still able to reproduce it, because Django logging extension (django.request and django.server) is still adding request to extras, which causes logs to be emitted with a request attribute containing an invalid value (WSGIRequest).

I didn't dig into it in detail, but what I imagine can solve the issue is to use a logging filter like:

class RequestFilter(logging.Filter):
    def filter(self, record: logging.LogRecord) -> bool:
        request = getattr(record, "request", None)
        record.request = str(request)
        return True
        
logger = logging.getLogger("django.request")
logger.addFilter(RequestFilter())

@emdneto Thank you for the suggestion, I have made the changes and the error is no longer being shown. Please refer to the before and after change screenshots -

BEFORE CHANGES -

AFTER CHANGE -

[rads-1996]

As per discussion in the python SIG, moved the logic to logging API - open-telemetry/opentelemetry-python#4808