[google-genai/spans] Define gcp.gen_ai.operation.config. attribute#3486
[google-genai/spans] Define gcp.gen_ai.operation.config. attribute#3486Rima-ag wants to merge 39 commits intoopen-telemetry:mainfrom
Conversation
… create a GCP-specific variants of the Gen AI documentation in support of this.
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
1 similar comment
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
|
||
| **Status:**  | ||
|
|
||
| Semantic Conventions for model inference spans when calling Google systems. |
There was a problem hiding this comment.
Wouldn't it make more sense to just list the non-standard sem-convs used by Gemini in this doc ?
Why list out all the existing sem convs ??
There was a problem hiding this comment.
I'm having trouble figuring out what new Gemini specific attribute is being added because the diff on this PR is so big
There was a problem hiding this comment.
Note we have deliberately moved away from pages which only lists extensions to pages which document the entire definition to provider the reader with a single location to look.
There is 2 options:
- model/gen-ai/spans.yaml shows what extensions & modifications are being done to the definitions
- we split this PR in 2. First uses the standard definitions aka no model changes & the second tailors it to gcp.
There was a problem hiding this comment.
I'm splitting this PR in 2 to make it easier to review
There was a problem hiding this comment.
I opened #3517 to add the standard definitions for google genai spans, could you please have a look? Once it is merged, it will be easier to review this PR that adds a new span attribute
563cfb0 to
21521af
Compare
Addresses comments on #2125
Copied Description from original PR
Fixes #2053
Changes
Defines a gcp.gen_ai.operation.config. dynamic attribute in support of Google Gen AI SDK instrumentation (see: open-telemetry/opentelemetry-python-contrib#3374). In support of this change, this also adds a Google-specific variant of the Gen AI docs. We anticipate that this will serve to enable additional documentation and Semantic Conventions for Google-specific elements beyond the dynamic request attributes being documented here.
Merge requirement checklist
*[N/A] schema-next.yaml updated with changes to existing conventions.