Skip to content

Add k8s.node.system_container.* metrics#3556

Open
PlateauGao wants to merge 10 commits intoopen-telemetry:mainfrom
PlateauGao:feat/k8s-node-system-container-metrics
Open

Add k8s.node.system_container.* metrics#3556
PlateauGao wants to merge 10 commits intoopen-telemetry:mainfrom
PlateauGao:feat/k8s-node-system-container-metrics

Conversation

@PlateauGao
Copy link
Copy Markdown

@PlateauGao PlateauGao commented Mar 17, 2026

Fixes #3531

Changes

Add k8s.node.system_container.* metrics and a self describing attribute k8s.node.system_container.name to capture node-level system daemon metrics." Please refer to the issue for detailed proposal

Important

Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.

Merge requirement checklist

  • [x ] CONTRIBUTING.md guidelines followed.
  • [ x] Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • [ x] Links to the prototypes or existing instrumentations (when adding or changing conventions)

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 17, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@PlateauGao PlateauGao force-pushed the feat/k8s-node-system-container-metrics branch from 7f23391 to a53e042 Compare March 17, 2026 18:52
@PlateauGao PlateauGao force-pushed the feat/k8s-node-system-container-metrics branch from e5fc292 to fc8eddf Compare March 17, 2026 19:36
@PlateauGao PlateauGao marked this pull request as ready for review March 17, 2026 19:37
@PlateauGao PlateauGao requested review from a team as code owners March 17, 2026 19:37
@PlateauGao PlateauGao force-pushed the feat/k8s-node-system-container-metrics branch from 42ad719 to fc8eddf Compare March 18, 2026 14:30
@PlateauGao
Copy link
Copy Markdown
Author

Hi @dashpole , I wonder if you could please take another look at this PR? Thanks!

of [Node.SystemContainers](https://github.com/kubernetes/kubelet/blob/v0.35.2/pkg/apis/stats/v1alpha1/types.go#L40)
of the Kubelet's stats API.
instrument: gauge
entity_associations:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k8s.node.system_container.name is only unique within a node (every node reports "kubelet", etc.), so an additional k8s.node.name/uid is needed to fully identify the system container. Would adding k8s.node to entity_associations on these metrics help make that dependency clearer? Not sure if we've discussed how to handle identity that depends on a parent entity in conventions yet

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/semconv-k8s-approvers any thoughts on this?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to adding it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PlateauGao
Copy link
Copy Markdown
Author

Hi @ChrsMark, I wonder what the process would be? I wonder if we need to wait for an approver and maintainer? Or I can try to reach out to one maintainer

@PlateauGao
Copy link
Copy Markdown
Author

Hi @jinja2, I wonder if you could please take another took and let me know if there is any other question? I think I need to have all comments resolved to get maintainer approval. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:k8s enhancement New feature or request

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Proposal: Add new node-level system daemon metrics k8s.node.system_container.*

4 participants