Add k8s.node.system_container.* metrics#3556
Add k8s.node.system_container.* metrics#3556PlateauGao wants to merge 10 commits intoopen-telemetry:mainfrom
Conversation
7f23391 to
a53e042
Compare
e5fc292 to
fc8eddf
Compare
42ad719 to
fc8eddf
Compare
|
Hi @dashpole , I wonder if you could please take another look at this PR? Thanks! |
| of [Node.SystemContainers](https://github.com/kubernetes/kubelet/blob/v0.35.2/pkg/apis/stats/v1alpha1/types.go#L40) | ||
| of the Kubelet's stats API. | ||
| instrument: gauge | ||
| entity_associations: |
There was a problem hiding this comment.
k8s.node.system_container.name is only unique within a node (every node reports "kubelet", etc.), so an additional k8s.node.name/uid is needed to fully identify the system container. Would adding k8s.node to entity_associations on these metrics help make that dependency clearer? Not sure if we've discussed how to handle identity that depends on a parent entity in conventions yet
There was a problem hiding this comment.
@open-telemetry/semconv-k8s-approvers any thoughts on this?
There was a problem hiding this comment.
I think this should be handled by Entity Relationships once https://github.com/open-telemetry/opentelemetry-specification/pull/4836/changes#diff-ad0266d8d6589d7477414924c759cbaedfc425f6926c31c972eb138ed9cf8d88R179 is in. @dmitryax WDYT?
|
Hi @ChrsMark, I wonder what the process would be? I wonder if we need to wait for an approver and maintainer? Or I can try to reach out to one maintainer |
|
Hi @jinja2, I wonder if you could please take another took and let me know if there is any other question? I think I need to have all comments resolved to get maintainer approval. Thanks! |
Fixes #3531
Changes
Add k8s.node.system_container.* metrics and a self describing attribute k8s.node.system_container.name to capture node-level system daemon metrics." Please refer to the issue for detailed proposal
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]