Expand dependency conflict resolution to allow different versions if major-version is compatible#1573
Conversation
jsuereth
commented
Jul 6, 2026
- Fix forge tests
- Add new tests for dependencies
- Implement very simple "latest version in major-series wins" conflict resolution algorithm
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
=======================================
- Coverage 82.3% 81.1% -1.3%
=======================================
Files 129 130 +1
Lines 11004 11514 +510
=======================================
+ Hits 9066 9344 +278
- Misses 1938 2170 +232 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| for (name, main_url) in main_dependencies.iter() { | ||
| if let Some(selected_url) = chosen_versions.get(name) { | ||
| if selected_url != main_url { | ||
| warnings.push(Error::ConversionError { |
There was a problem hiding this comment.
is this a warning/NFE ? ConversionError seems to be regular error
|
This PR has review comments. Review suggestions, whether from maintainers or automated reviewers, aren't always correct or required. Please evaluate each comment on its merits, then make sure each thread has a clear outcome. For example, link to the commit if you applied a suggestion, explain why it wasn't applied, or ask a follow-up question. Automation flags a PR for human review once every review thread has a reply or is marked as resolved. Status across open PRs is visible on the pull request dashboard. |