This repository was archived by the owner on Oct 25, 2024. It is now read-only.
fix decode HEVC format description#200
Open
juicechu wants to merge 2 commits into
Open
Conversation
Collaborator
|
Thanks for reporting this issue. If video format is not available at receiver side, it sends a key frame request to the sender. Did you observe this error even a key frame is received? |
|
I just had the same issue and found the same solution, I did the change in sdk/objc/components/video_codec/RTCVideoDecoderH265.mm to actually call the description function of H265, this made the video stream work. Would be great if this fix could be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I change the script from
rtc_use_h265=falsetortc_use_h265=true, I found the H265 decode is broken. I get the error message is "Missing video format. Frame with sps/pps required. ". So that is caused by the decoding the HEVC format not correctly.