Refactor BsRequest creation to reduce deadlock risk#19308
Open
rubhanazeem wants to merge 1 commit intoopenSUSE:masterfrom
Open
Refactor BsRequest creation to reduce deadlock risk#19308rubhanazeem wants to merge 1 commit intoopenSUSE:masterfrom
rubhanazeem wants to merge 1 commit intoopenSUSE:masterfrom
Conversation
Remove the outer transaction block to release write locks as soon as possible and moved the validation outside the transaction. This reduces database lock time hence reduces the possibility of Deadlock errors
rubhanazeem
force-pushed
the
rm-transation-req-create
branch
from
a368da9 to
42fb981
Compare
hennevogel
reviewed
Apr 8, 2026
| @req.set_add_revision if params[:addrevision].present? | ||
| @req.set_ignore_delegate if params[:ignore_delegate].present? | ||
| @req.set_ignore_build_state if params[:ignore_build_state].present? | ||
| @req.save! |
Member
There was a problem hiding this comment.
Hm, and what replaces the transaction functionality?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr removes the outer transaction block to release write locks as soon as possible and moved the validation outside the transaction. This reduces database lock time hence reduces the possibility of Deadlock errors in request creation.
There are some
Mysql2::Error: Deadlockexceptions noted down in Errbit because of this