Improve handling of large diffs in WebUI#19320
Open
Sahitya0805 wants to merge 1 commit intoopenSUSE:masterfrom
Open
Improve handling of large diffs in WebUI#19320Sahitya0805 wants to merge 1 commit intoopenSUSE:masterfrom
Sahitya0805 wants to merge 1 commit intoopenSUSE:masterfrom
Conversation
Sahitya0805
force-pushed
the
fix/issue-17856-large-diff-handling
branch
5 times, most recently
from
c1dc953 to
fcdf2e3
Compare
Sahitya0805
force-pushed
the
fix/issue-17856-large-diff-handling
branch
2 times, most recently
from
6410e3c to
543112c
Compare
github-actions
bot
added
Backend
Sahitya0805
force-pushed
the
fix/issue-17856-large-diff-handling
branch
2 times, most recently
from
f54f0a4 to
04e1c1f
Compare
Sahitya0805
changed the title
Sahitya0805
changed the title
Sahitya0805
force-pushed
the
fix/issue-17856-large-diff-handling
branch
5 times, most recently
from
728d370 to
c5d0168
Compare
Sahitya0805
force-pushed
the
fix/issue-17856-large-diff-handling
branch
from
c5d0168 to
ffad473
Compare
hennevogel
requested changes
Mar 12, 2026
| Some of the changes are collapsed due to size. | ||
| = link_to(request_changes_path(@bs_request, @action, tarlimit: 0)) do | ||
| Expand changes | ||
| - if truncated? && User.session |
Member
There was a problem hiding this comment.
You just switched around the logic from expandable? to truncated?. But this doesn't change any behavior. Especially none of the behaviors requested in #17856
Do you understand what you are doing or do you just page genAI output here?
Sahitya0805
force-pushed
the
fix/issue-17856-large-diff-handling
branch
from
ffad473 to
fba01c4
Compare
Sahitya0805
force-pushed
the
fix/issue-17856-large-diff-handling
branch
10 times, most recently
from
b593f6b to
388578a
Compare
Sahitya0805
force-pushed
the
fix/issue-17856-large-diff-handling
branch
3 times, most recently
from
51c4b12 to
6d4f503
Compare
Member
|
@Sahitya0805 you are mixing bug fixes and refactorings in one PR which makes this very hard to review. See https://medium.com/@kentbeck_7670/bs-changes-e574bc396aaa for an explanation... |
Sahitya0805
force-pushed
the
fix/issue-17856-large-diff-handling
branch
6 times, most recently
from
80caf2a to
3281939
Compare
- Add repeated truncation warning at the point of truncation (per-file) - Add bottom-of-page warning in SourcediffComponent for better visibility - Use inline HAML logic for truncation check to keep classes original - Remove all unrelated workflow and refactoring noise
Sahitya0805
force-pushed
the
fix/issue-17856-large-diff-handling
branch
from
3281939 to
343cad5
Compare
Contributor
Author
|
Sorry, and thanks for the feedback. You're right the previous version mixed refactoring with the actual fix, which made it harder to review. I've now cleaned up the PR and kept it strictly focused on the intended behavior change. To clarify the fix:
I've limited the changes to the relevant HAML views and added a unit test to verify the warning is rendered when diffs are truncated. Please let me know if you'd prefer this to be split further or adjusted in any way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve handling of large diffs in the WebUI by ensuring truncation warnings are clearly visible at the point where the diff is cut off.
Problem
Currently, when a diff is truncated in the WebUI, the warning message is not always visible at the exact truncation point.
This makes it unclear to users that the displayed diff is incomplete, especially when scrolling through large files.
Solution
Changes
Verification
Run:
bundle exec rspec spec/components/sourcediff_component_spec.rb