Fix AnityaDistribution version detection with set_version service#19375
Open
Sahitya0805 wants to merge 1 commit intoopenSUSE:masterfrom
Open
Fix AnityaDistribution version detection with set_version service#19375Sahitya0805 wants to merge 1 commit intoopenSUSE:masterfrom
Sahitya0805 wants to merge 1 commit intoopenSUSE:masterfrom
Conversation
Member
|
This PR includes a commit "Fix crash when creating an existing patchinfo package issue" not related to fixing the issue... |
Contributor
Author
|
Thanks for pointing that out! You’re right — the patchinfo fix addresses a different issue. |
f6587e1 to
c9e8bbf
Compare
cdf88d0 to
758732d
Compare
15386a5 to
6b4666f
Compare
6b4666f to
21a9b96
Compare
21a9b96 to
3e2ef49
Compare
hennevogel
reviewed
Mar 16, 2026
3e2ef49 to
917345e
Compare
Contributor
Author
|
Thanks for the clarification! I've removed the test and kept the PR focused on the fix. |
2fd53cd to
22fc9ec
Compare
e3afecb to
ccaf7a8
Compare
ccaf7a8 to
5145bf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi friends,
This PR fixes an issue where AnityaDistribution reports an incorrect package version when the
set_versionservice is used in buildtime mode.In such cases, the version defined in the
.specfile remains unchanged, while the actual version is updated dynamically by the_serviceduring build time. As a result, the detected version was not reflecting the effective version produced by the service.Fix
This change updates the version detection logic to prefer the version from
_service-generatedsourceinfoentries (identified via_service:filenames), and falls back to the default sourceinfo when not present.Why this approach
Result
The detected version now correctly reflects the version modified by the
set_versionservice.Fixes: #18610
Thanks!