Cache notification unread counter#19559
Open
krauselukas wants to merge 2 commits intoopenSUSE:masterfrom
Open
Conversation
We render the unread count value of notifications everywhere in the webui in the navigation bars, to indicate how many notifications a user received. So every page load in OBS hits the database and performs a count over the notifications. By caching the value, we can safe a lot of database queries.
To avoid silent and frustrating bugs due to stale cache entries, adding some specs to ensure the cache for the unread notifications count of a user gets deleted after they get marked as read or unread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We render the unread count value of notifications everywhere in the webui
in the navigation bars, to indicate how many notifications a user
received. So every page load in OBS hits the database and performs a
count over the notifications.
By caching the value, we can safe a lot of database queries.