feat: add /codex:diff-review, /codex:watch, /codex:config and codex:optimize#146
feat: add /codex:diff-review, /codex:watch, /codex:config and codex:optimize#146durgeshmahajann wants to merge 1 commit intoopenai:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d01920d8aa
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| { | ||
| "codex:optimize": "scripts/codex-companion.mjs" | ||
| } No newline at end of file |
There was a problem hiding this comment.
The file now contains two top-level JSON objects, so hooks.json is not parseable JSON anymore. Any loader that reads this hooks config will fail before registering hooks, which can disable all hook behavior (including existing SessionStart/SessionEnd/Stop hooks), not just the new watch hook.
Useful? React with 👍 / 👎.
| if (result.stdout) { | ||
| try { | ||
| // The prompt asks Codex to embed pr_description in the JSON output | ||
| const parsed = JSON.parse(result.stdout); |
There was a problem hiding this comment.
executeReviewRun() returns structured data under payload/rendered, but this branch reads result.stdout, which is never set by that function. As a result, prDescription is always null and the command always falls back to the generic template instead of using Codex-generated PR text.
Useful? React with 👍 / 👎.
| return { | ||
| ...result, | ||
| stdout: (result.stdout ?? "") + "\n" + footer | ||
| }; |
There was a problem hiding this comment.
This modifies stdout, but foreground execution prints and stores execution.rendered, not execution.stdout (see runForegroundCommand/runTrackedJob usage). In practice the “PR description written to …” footer is dropped, so users are not told where the generated file was saved.
Useful? React with 👍 / 👎.
| case "optimize": | ||
| console.log("⚡ Optimize feature working!"); | ||
| break; |
There was a problem hiding this comment.
The new optimize branch only prints a static string and exits, so invoking the advertised optimize command does not run any Codex analysis or job flow. This makes the feature effectively non-functional for users who call the subcommand.
Useful? React with 👍 / 👎.
1 participant
What
Adds four new features on top of the upstream plugin:
/codex:diff-review— runs Codex review + generates draft PR description, saves to file/codex:watch— auto-queues a Codex lint pass after every file Claude writes/codex:config— read/write .codex/config.toml without manual editingcodex:optimize— performance-focused Codex review agentWhy
The original plugin had no way to generate PR descriptions automatically,
no continuous feedback during a Claude session, and no easy way to
change Codex config without knowing TOML syntax.
How
post-tool-use-watch-hook.mjs— new PostToolUse hooklib/toml.mjs— zero-dependency TOML reader/writerhandleDiffReview(),handleWatch(),handleConfig()in codex-companion.mjsTesting
All existing tests pass unchanged. New features are off by default.