Skip to content

fix: avoid embedding large adversarial review diffs#179

Merged
dkundel-openai merged 5 commits intomainfrom
codex/plugin-large-diff-fix
Apr 8, 2026
Merged

fix: avoid embedding large adversarial review diffs#179
dkundel-openai merged 5 commits intomainfrom
codex/plugin-large-diff-fix

Conversation

@dkundel-openai
Copy link
Copy Markdown
Collaborator

Summary

  • Fixes /codex:adversarial-review failing on larger diffs by using the initial changed-file count to decide whether to inline the diff.
  • Keeps inline diff context for small review scopes.
  • Uses lightweight review context for larger scopes and instructs Codex to inspect the target diff itself with read-only git commands.
  • Adds regression coverage for both inline and self-inspection paths.

Closes #11

Testing

  • node --test tests/git.test.mjs tests/runtime.test.mjs tests/commands.test.mjs

@dkundel-openai dkundel-openai requested a review from a team April 8, 2026 03:19
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3e5c47a62d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f4d107092d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dkundel-openai dkundel-openai merged commit bc8fa66 into main Apr 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adversarial-review crashes on large diffs (ENOBUFS / input limit exceeded)

1 participant