[codex] sanitize codex child process env#190
Open
seungpyoson wants to merge 4 commits intoopenai:mainfrom
Open
[codex] sanitize codex child process env#190seungpyoson wants to merge 4 commits intoopenai:mainfrom
seungpyoson wants to merge 4 commits intoopenai:mainfrom
Conversation
Author
|
Requesting adversarial review. Focus areas:
Validation already run on this branch:
PR: #190 |
Author
|
Follow-up pushed in response to review:
Latest validation on branch:
Both are passing on the updated branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sanitizeChildEnvhelper inplugins/codex/scripts/lib/process.mjs"$ARGUMENTS"command formWhy
This was surfaced by
seungpyoson/claude-config#525.The Codex marketplace plugin was forwarding ambient Rust verification routing variables across plugin process boundaries. The plugin did not expose a shared sanitizer, and downstream boundary tests were correctly identifying that drift.
Impact
Validation
node --test tests/process.test.mjsnpm test