Avoid mutating dicts in jsondumps#1678
Open
RaghunandanKumar wants to merge 1 commit into
Open
Conversation
RaghunandanKumar
requested review from
andrew-openai,
etr2460 and
katyhshi
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsondumps(..., exclude_keys=...)is usedKeyErrorWhy
jsondumpspreviously deleted excluded keys directly from dictionary inputs before encoding. That produced surprising side effects for callers that reused the same object after serialization, and it also raised when an excluded key was absent.Verification
OPENAI_API_KEY=dummy uv run --python 3.11 pytest evals/data_test.py evals/record_test.py tests/unit/evals/test_metrics.py