Skip to content

Fix ResponseContentPart kind setter#1228

Open
fallintoplace wants to merge 1 commit into
openai:mainfrom
fallintoplace:fix/response-content-kind-setter
Open

Fix ResponseContentPart kind setter#1228
fallintoplace wants to merge 1 commit into
openai:mainfrom
fallintoplace:fix/response-content-kind-setter

Conversation

@fallintoplace

Copy link
Copy Markdown

Summary

  • fix ResponseContentPart.Kind to use the assigned value when updating InternalType
  • add a smoke regression that exercises the private setter and verifies the backing type is updated

Notes

  • the current ResponseContentPart JSON deserialization path appears to set InternalType directly through concrete internal content types, so this looks like a latent correctness fix rather than a confirmed live deserialization failure
  • I was not able to run the test suite locally because the dotnet SDK is not installed in this environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant