fix: skip empty-data SSE events per HTML5 spec#651
Open
Chronostasys wants to merge 1 commit into
Open
Conversation
Some LLM providers (e.g. Xiaomi MiMo) send keep-alive comments like ': PROCESSING\n\n' during streaming. The empty line dispatches an event with empty data, which json.Unmarshal then fails on with 'unexpected end of JSON input'. Per the HTML5 SSE specification, events with empty data buffers should be silently discarded. This patch adds a data.Len() == 0 check in eventStreamDecoder.Next() to skip such events instead of dispatching them. Fixes compatibility with providers that use SSE comments as keep-alive signals during model processing.
a19c262 to
a655caf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some LLM providers (e.g. Xiaomi MiMo) send keep-alive comments during streaming:
This produces an SSE event with empty
Data. The currenteventStreamDecoder.Next()dispatches it, andStream[T].Next()then callsjson.Unmarshal([]byte{}, ...)which returns"unexpected end of JSON input"— crashing the stream.Root Cause
The HTML5 SSE specification states:
Events with empty data should be silently discarded. The current implementation dispatches them regardless.
Fix
In
eventStreamDecoder.Next(), when a blank line triggers event dispatch, check ifdata.Len() == 0. If so, reset state andcontinueinstead of returning the empty event.Testing
Added
ssestream_test.gowith 5 test cases:All tests pass.
Compatibility