Skip to content

fix: log retry count at INFO level (#2404) #3072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinmalana wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −12
Open

fix: log retry count at INFO level (#2404) #3072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/openai/_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,13 +1102,8 @@ def _sleep_for_retry(
self, *, retries_taken: int, max_retries: int, options: FinalRequestOptions, response: httpx.Response | None
) -> None:
remaining_retries = max_retries - retries_taken
if remaining_retries == 1:
log.debug("1 retry left")
else:
log.debug("%i retries left", remaining_retries)

timeout = self._calculate_retry_timeout(remaining_retries, options, response.headers if response else None)
log.info("Retrying request to %s in %f seconds", options.url, timeout)
log.info("Retrying request to %s in %f seconds (retry %d of %d)", options.url, timeout, retries_taken, max_retries)
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Report the next retry attempt, not completed retries

This log message is off by one because _sleep_for_retry() is called before the next attempt starts, but it prints retries_taken (the number of retries already completed). On the first retry path (retries_taken == 0), users will see retry 0 of N, and the final retry is logged as retry N-1 of N, which makes the new INFO-level retry counter misleading for troubleshooting in both sync and async clients. Log retries_taken + 1 (or equivalent) to reflect the retry that is about to happen.

Useful? React with 👍 / 👎.


time.sleep(timeout)

Expand Down Expand Up @@ -1713,13 +1708,8 @@ async def _sleep_for_retry(
self, *, retries_taken: int, max_retries: int, options: FinalRequestOptions, response: httpx.Response | None
) -> None:
remaining_retries = max_retries - retries_taken
if remaining_retries == 1:
log.debug("1 retry left")
else:
log.debug("%i retries left", remaining_retries)

timeout = self._calculate_retry_timeout(remaining_retries, options, response.headers if response else None)
log.info("Retrying request to %s in %f seconds", options.url, timeout)
log.info("Retrying request to %s in %f seconds (retry %d of %d)", options.url, timeout, retries_taken, max_retries)

await anyio.sleep(timeout)

Expand Down