feat(dataflow): known bits analysis - #1374
Draft
axelcool1234 wants to merge 6 commits into
Draft
axelcool1234 wants to merge 6 commits into
axelcool1234 wants to merge 6 commits into
Conversation
axelcool1234
marked this pull request as draft
September 4, 2026 08:08
axelcool1234
force-pushed
the
known-bits
branch
7 times, most recently
from
September 10, 2026 18:42
03ac6ba to
bc01901
Compare
Collaborator
|
one thing you should add here is an invariant on the known bits struct that no bit is known both zero and one. another thing you should do is to think carefully about top. here you have an explicit representation for it, but there's another representation, which is that no bits are known. it's a mistake to be able to represent the same value two different ways. you should either remove the explicit top or else use another invariant on the struct to enforce that at least one bit is always known. |
axelcool1234
force-pushed
the
known-bits
branch
3 times, most recently
from
September 12, 2026 19:14
51c638c to
d523ccc
Compare
axelcool1234
force-pushed
the
known-bits
branch
from
September 15, 2026 02:46
d523ccc to
2ee3bbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.