feat(llzk): more local invariants checks (array), refactor common checks - #1389
Open
Maschmalow wants to merge 2 commits into
Open
Maschmalow wants to merge 2 commits into
Maschmalow wants to merge 2 commits into
Conversation
…ks, updated constraint and struct checks
Maschmalow
marked this pull request as ready for review
September 4, 2026 18:46
tobiasgrosser
approved these changes
Sep 10, 2026
tobiasgrosser
left a comment
tobiasgrosser
left a comment
Collaborator
There was a problem hiding this comment.
This LGTM. @AlexanderViand, what do you think?
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
AlexanderViand
approved these changes
Sep 13, 2026
AlexanderViand
left a comment
AlexanderViand
left a comment
Contributor
There was a problem hiding this comment.
I asked Claude to check this against LLZK (ba936ff) and it looks good, veir-opt seems to be a bit more permissive than llzk-opt, but that seems OK for now.
It would be nice to add some tests, but probably not super essential given that the source of truth is LLZK anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifier.Basicand refactor existing usage