chore(lean) : update lean to version 4.34.0 - #1472
Merged
Merged
Conversation
math-fehr
force-pushed
the
math-fehr/lean-update
branch
from
September 16, 2026 03:35
b49d5b8 to
827adda
Compare
math-fehr
marked this pull request as ready for review
September 16, 2026 03:37
Collaborator
Author
|
All good now, I updated it to |
math-fehr
force-pushed
the
math-fehr/lean-update
branch
from
September 16, 2026 04:01
827adda to
5b822d1
Compare
tobiasgrosser
approved these changes
Sep 16, 2026
tobiasgrosser
left a comment
tobiasgrosser
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, assuming we have a good answer to my comment.
| operation.getSuccessors! ctx := by | ||
| simp only [OperationPtr.getSuccessors!_def] | ||
| grind | ||
| grind [-Array.range'_append, -Array.range'_append_1] |
Collaborator
There was a problem hiding this comment.
Having to drop simp lemmas is a bit concerning. Do we understand why this is happening?
Collaborator
Author
There was a problem hiding this comment.
This is a small reproducer of the bug in latest lean version:
leanprover/lean4#15183
Collaborator
There was a problem hiding this comment.
OK, then we can move along and fix it when the bug is resolved. You may want to add a comment to the relevant Lean bug in the code to ensure things we can revert this when the bug is resolved.
math-fehr
force-pushed
the
math-fehr/lean-update
branch
from
September 16, 2026 17:01
5b822d1 to
fa51a2d
Compare
math-fehr
force-pushed
the
math-fehr/lean-update
branch
from
September 17, 2026 00:33
fa51a2d to
2f502c0
Compare
math-fehr
enabled auto-merge
September 17, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update lean to the latest release candidate version (4.35.0-rc1). 4.34.0 sadly has a bug in bv_decide that prevents us from using it.
The following changes were made:
native_decideinstead ofcbvin a Puddle tactic, as there is a bug in Lean: https://live.lean-lang.org/#codez=JYWwDg9gTgLgBAGQKYEMB2AoJAPF4A2ScAXBnOXABTABmcAKlAK5EwAWSacAzhCEQAUAqmmAwAdE1Hwk%2BbkUpoIaIsTgB5MDGDK4w6QEoDZCuQC8PPoJFjJ0khYBGATzgBjRwDcgA