Skip to content

Fix status checking codes with TCG Block SID Authentication feature #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NKamimura-2025 wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix status checking codes with TCG Block SID Authentication feature #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
871bd3f
Fix codes related to checking TCG Block SID Authentication feature be…
NKamimura-2025 Sep 26, 2025
fda57d0
Merge branch 'dev' of https://github.com/NKamimura-2025/ocp-diag-auto…
NKamimura-2025 Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/autoval_ssd/lib/utils/storage/nvme/nvme_drive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1420,8 +1420,6 @@ def get_tcg_ownership_status(self) -> OwnershipStatus:
sid_auth_blocked_state = (byte_0xA8_int >> 1) & 1
if sid_state and not sid_auth_blocked_state:
return OwnershipStatus.SET
if sid_auth_blocked_state and sid_state:
return OwnershipStatus.BLOCKED_AND_SET
if sid_auth_blocked_state and not sid_state:
return OwnershipStatus.BLOCKED_AND_NOT_SET
if not sid_state and not sid_auth_blocked_state:
Expand Down
2 changes: 1 addition & 1 deletion src/autoval_ssd/tests/sed_check/sed_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def execute(self) -> None:
str(drive.get_tcg_ownership_status()),
[
str(OwnershipStatus.SET),
str(OwnershipStatus.BLOCKED_AND_SET),
str(OwnershipStatus.BLOCKED_AND_NOT_SET),
],
"validating the drive ownership status"
f" {drive.block_name} {drive.serial_number}",
Expand Down