Conversation
ningmingxiao
requested review from
cyphar,
kolyshkin,
mrunalp,
rhatdan,
runcom and
thaJeztah
as code owners
ningmingxiao
force-pushed
the
dev03
branch
4 times, most recently
from
931123f to
c28240d
Compare
go-selinux/selinux_linux.go
Outdated
|
|
||
| func GetContainerLabelsSize() int { |
There was a problem hiding this comment.
| func GetContainerLabelsSize() int { | |
| func ContainerLabelsSize() int { |
Per Go coding guidelines, Get should not be used (see https://google.github.io/styleguide/go/decisions#getters).
I know we have GetEnabled but it's the only function.
There was a problem hiding this comment.
I also don't like the fact that we introduce a new public function which is not really used anywhere except in our own code.
There was a problem hiding this comment.
I have to introduce a new public function.
ningmingxiao
force-pushed
the
dev03
branch
2 times, most recently
from
d083957 to
4567cb2
Compare
|
LGTM |
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
Maybe we need to change the public API to add error reporting to, say, selinux.ContainerLabels (and similar functions using addMcs/uniqMcs)?
Keep the old functions for backward compatibility but deprecate those?
I afraid user have to adapt to the new interface and we can't let user know old interface is deprecate. @kolyshkin |
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
3 participants
No description provided.