use inverted index to serve labels/label_values instead of forward - #13
Merged
Conversation
Contributor
Author
|
I'm going to optimistically merge this to unblock some perf testing, but it's definitely wroth specifying all the query paths in an RFC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The original approach was embarrassingly bad... I can't believe I merged it that way! I had to change it from the Aion implementation because we don't have explicit dictionaries.
labels()andlabel_values()endpoints to use inverted index keys instead of iterating through forward indexInvertedIndexKey::attribute_range()for efficient storage scans by label nameQueryReader::label_values()method that scans only keys matching the requested labelTest plan
attribute_range()key matchinglabels()andlabel_values()endpoints cover both filtered and unfiltered casesChecklist
cargo fmtandcargo clippypass